@Veykril , could you have a look?

There are ways to return the existing bits of "qualify the assoc item" functionality if you're interested in it now, but it'll work for the current crate's items only.

Hmm, we don't necessarily need to get rid of all associated item completions. Regarding the issue in the Zulip thread, IMO it'd also be fine to complete ToChalk::from_chalk; the problem is that there's a suggestion for each impl of the trait.

But ToChalk::from_chalk won't compile without us explicitly specifying which impl to use?
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e717f2e134d2936e7ae0243f13e9928b

That was my reasoning for excluding such cases at least: we cannot guess which impl to use without the user helping us and having just the trait is not enough.

We could instead propose the corresponding structs and their assoc items, but that's unavailable for a number of reasons, ergo also excluded and the test ignored.

I personally don't see too much of a problem in not seeing associated items I think, at least for now? I don't think I can tell until I'm missing it though 😄 It would certainly be nice to at least have it for non-trait impls but if I saw that right reading the comment that will take quite a bit of work to be doable efficiently.

But ToChalk::from_chalk won't compile without us explicitly specifying which impl to use?

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=71fd67cdf4b5d7520420af4475a71824 🙂
You're using this all the time when writing Default::default().
I'm not totally convinced that we should have this either, though. (Actually I'd probably personally prefer not having them.)

I'm actually following some of the pedantic clippy rules and always write Struct::default() 🙂
But it's a great example, now I understand where else the qualifier can come from, thank you.

I'm also not sure we should have this kinds of completions, not right away at least: it feels like I have to write way more code and tests to properly support such cases, so let's prohibit them for a while and iterate on top.

bors r+

changelog fix

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)